llm: Ignore acknowledgements drift in the SDK-update-evaluate job - #2984
Conversation
Every Debug build regenerates Settings.bundle acknowledgements via LicensePlist, unrelated to the SDK bump the workflow evaluates. That dirtied tracked files before the push step's uncommitted-changes guard ran, failing the job regardless of whether the agent's fix was clean. Mark those paths skip-worktree right after checkout, so git ignores changes to them for the rest of the job no matter how many Debug builds run.
github-actions
Bot
added
the
t:llm
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds a single step to Code Review DetailsNo findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
- Coverage 79.50% 79.50% -0.01%
==========================================
Files 1169 1169
Lines 75028 75028
==========================================
- Hits 59650 59649 -1
- Misses 15378 15379 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
🎟️ Tracking
AI-78
📔 Objective
The SDK-update-evaluate workflow was failing on drift it introduces itself. Every Debug build, including the workflow's baseline build and the agent's own verify build, regenerates Settings.bundle acknowledgements via LicensePlist, unrelated to the SDK bump being evaluated, and that dirtied tracked files enough to trip the push step's uncommitted-changes guard regardless of whether the agent's fix was clean. Marks those paths
skip-worktreeright after checkout so the rest of the job never sees the drift.